[
https://issues.apache.org/jira/browse/YARN-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970416#comment-15970416
]
Billie Rinaldi commented on YARN-6335:
--------------------------------------
bq. I wonder why "yarn.resource.normalization.enabled" is introduced.
This is pulling in changes made in SLIDER-1201, so that I would not have to
make significant changes to TestRoleHistoryOutstandingRequestTracker (which
tests the resource normalization feature).
bq. In SliderClient#actionDestroy: IIUC, the last check of findAllLiveInstances
cannot prevent the mentioned race condition
This is a good point. Maybe we should check for the existence of the app
directory instead of checking for a live app? It would be nice to give the user
a heads up that their app might be in an unexpected state.
bq. Looks like most of the tests are testing individual method only, we may
need to add some end-to-end tests at some point.
Yes, these are only the basic unit tests that could be translated from groovy
to Java. I think it will be easier to add some end-to-end tests (possibly
porting other existing tests) once we have a provider service that doesn't
require docker.
Thanks for the review, [~jianhe]! I'll work on restructuring the test packages.
> Port slider's groovy unit tests to yarn native services
> -------------------------------------------------------
>
> Key: YARN-6335
> URL: https://issues.apache.org/jira/browse/YARN-6335
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Fix For: yarn-native-services
>
> Attachments: YARN-6335-yarn-native-services.001.patch,
> YARN-6335-yarn-native-services.002.patch,
> YARN-6335-yarn-native-services.003.patch,
> YARN-6335-yarn-native-services.004.patch
>
>
> Slider has a lot of useful unit tests implemented in groovy. We could convert
> these to Java for YARN native services. This scope of this ticket will
> include unit / minicluster tests only and will not include Slider's funtests
> which require a running cluster.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
