[ 
https://issues.apache.org/jira/browse/YARN-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976775#comment-15976775
 ] 

Billie Rinaldi commented on YARN-6335:
--------------------------------------

bq. I see, the config name is confusing then. Normalization is always done in 
yarn no matter whether client does it or not. IMO, there's difference between 
normalization and validation. The validation for invalid requests should always 
be done at job submission to fail such requests upfront. This is what the API 
GetNewApplicationResponse#getMaximumResourceCapability meant for. Silently let 
the app continue with an invalid resource requests is just making user 
confusing later. An arbitrary large resource request should always not be 
allowed similar to a negative resource.

Makes sense. We should discuss with [~gsaha] who implemented this feature. I 
think that he also did work to make sure that the later exceptions were easily 
visible to the user, but maybe it would be better to fail faster.

> Port slider's groovy unit tests to yarn native services
> -------------------------------------------------------
>
>                 Key: YARN-6335
>                 URL: https://issues.apache.org/jira/browse/YARN-6335
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>             Fix For: yarn-native-services
>
>         Attachments: YARN-6335-yarn-native-services.001.patch, 
> YARN-6335-yarn-native-services.002.patch, 
> YARN-6335-yarn-native-services.003.patch, 
> YARN-6335-yarn-native-services.004.patch, 
> YARN-6335-yarn-native-services.005.patch, 
> YARN-6335-yarn-native-services.006.patch, 
> YARN-6335-yarn-native-services.007.patch
>
>
> Slider has a lot of useful unit tests implemented in groovy. We could convert 
> these to Java for YARN native services. This scope of this ticket will 
> include unit / minicluster tests only and will not include Slider's funtests 
> which require a running cluster.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to