[
https://issues.apache.org/jira/browse/YARN-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972248#comment-15972248
]
Jian He commented on YARN-6335:
-------------------------------
bq. This is pulling in changes made in SLIDER-1201, so that I would not have to
make significant changes to TestRoleHistoryOutstandingRequestTracker (which
tests the resource normalization feature).
One confusion about the semantics. Looks like the
"yarn.resource.normalization.enabled" will only control whether slider AM will
normalize the request at client side or not. But, regardless of this setting,
the normalization will always be done in YARN scheduler to round up the
resource size. So, this config does not seem solve the mentioned use-case in
SLIDER-1201 ? Basically, because scheduler is always doing normalization, this
config is not useful.
- What's the difference between these two paths: the path defined in
deleteZookeeperNode and the path defined by registryPathForInstance ? The paths
for these two look very similar,
{code}
if (!deleteZookeeperNode(appName)) {
String message =
"Failed to cleanup cleanup application " + appName + " in zookeeper";
log.warn(message);
throw new YarnException(message);
}
//TODO clean registry?
String registryPath = SliderRegistryUtils.registryPathForInstance(
appName);
{code}
bq. Maybe we should check for the existence of the app directory instead of
checking for a live app?
Even if we check the existence of app Dir at last line of the method, if the
create happens to be done right after this check and before the method returns,
it is still the same problem. To user this just looks as if the create
immediately happens after destroy. It is a micro optimization, but the
semantics is still not deterministic.
> Port slider's groovy unit tests to yarn native services
> -------------------------------------------------------
>
> Key: YARN-6335
> URL: https://issues.apache.org/jira/browse/YARN-6335
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Fix For: yarn-native-services
>
> Attachments: YARN-6335-yarn-native-services.001.patch,
> YARN-6335-yarn-native-services.002.patch,
> YARN-6335-yarn-native-services.003.patch,
> YARN-6335-yarn-native-services.004.patch,
> YARN-6335-yarn-native-services.005.patch
>
>
> Slider has a lot of useful unit tests implemented in groovy. We could convert
> these to Java for YARN native services. This scope of this ticket will
> include unit / minicluster tests only and will not include Slider's funtests
> which require a running cluster.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
