[
https://issues.apache.org/jira/browse/YARN-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983699#comment-15983699
]
Eric Payne commented on YARN-2113:
----------------------------------
Thanks [~sunilg]. I have one more (last?) concern.
Shouldn't the following code be {{lessThanOrEqual}} instead of {{lessThan}}?
The scheduler always assigns one more container than the UL, so I think that if
removing this container brings the user down to equal its UL, the scheduler
would give the container back to the user:
{code:title=IntraQueueCandidatesSelector#preemptFromLeastStarvedApp}
// If selected container brings down resource usage under its user's
// UserLimit, we must skip such containers.
if (Resources.lessThan(rc, clusterResource,
Resources.subtract(userResourceUsage, c.getAllocatedResource()),
computedUserLimitPerUser.get(app.getUser()))
&& preemptionContext.getIntraQueuePreemptionOrder()
.equals(IntraQueuePreemptionOrder.USERLIMIT_FIRST)) {
{code}
> Add cross-user preemption within CapacityScheduler's leaf-queue
> ---------------------------------------------------------------
>
> Key: YARN-2113
> URL: https://issues.apache.org/jira/browse/YARN-2113
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Sunil G
> Attachments:
> TestNoIntraQueuePreemptionIfBelowUserLimitAndDifferentPrioritiesWithExtraUsers.txt,
> YARN-2113.0001.patch, YARN-2113.0002.patch, YARN-2113.0003.patch,
> YARN-2113.0004.patch, YARN-2113.0005.patch, YARN-2113.0006.patch,
> YARN-2113.0007.patch, YARN-2113.0008.patch, YARN-2113.0009.patch,
> YARN-2113.0010.patch, YARN-2113.v0.patch
>
>
> Preemption today only works across queues and moves around resources across
> queues per demand and usage. We should also have user-level preemption within
> a queue, to balance capacity across users in a predictable manner.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
