[
https://issues.apache.org/jira/browse/YARN-6681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034902#comment-16034902
]
Daryn Sharp commented on YARN-6681:
-----------------------------------
Should/could I just unconditionally return true for a parent queue? A RW lock
is ridiculously expensive to fetch the size. I tried to make minimal/low risk
changes for an internal build to get us unblocked but it would seem to make
sense. My hesitation was the null check on childQueues, implying an iteration
would NPE, but it's marked final so always returning true seems safe?
> Eliminate double-copy of child queues in canAssignToThisQueue
> -------------------------------------------------------------
>
> Key: YARN-6681
> URL: https://issues.apache.org/jira/browse/YARN-6681
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.8.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: YARN-6681.branch-2.8.patch, YARN-6681.branch-2.patch,
> YARN-6681.trunk.patch
>
>
> 20% of the time in {{AbstractCSQueue#canAssignToThisQueue}} is spent
> performing two duplications a treemap of child queues into a list - once to
> test for null, second to see if it's empty. Eliminating the dups reduces the
> overhead to 2%.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
