[
https://issues.apache.org/jira/browse/YARN-6681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057664#comment-16057664
]
Daryn Sharp commented on YARN-6681:
-----------------------------------
bq. is it not good enough that leaf queue returns false and parent queue
returns true ?
I don't know. I tried to make the absolute minimal no-risk change that
preserves existing semantics, as dubious as they may be.
The parent queue currently returns false if it has no child queues, so always
returning true changes the existing semantics. Likewise, a leaf queue subclass
currently can claim to have child queues, so always returning false changes the
semantics.
I'd suggest integrating the current patch(es) and use another jira for further
changes/optimizations that change semantics?
> Eliminate double-copy of child queues in canAssignToThisQueue
> -------------------------------------------------------------
>
> Key: YARN-6681
> URL: https://issues.apache.org/jira/browse/YARN-6681
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.8.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: YARN-6681.2.branch-2.8.patch,
> YARN-6681.2.branch-2.patch, YARN-6681.2.trunk.patch,
> YARN-6681.branch-2.8.patch, YARN-6681.branch-2.patch, YARN-6681.trunk.patch
>
>
> 20% of the time in {{AbstractCSQueue#canAssignToThisQueue}} is spent
> performing two duplications a treemap of child queues into a list - once to
> test for null, second to see if it's empty. Eliminating the dups reduces the
> overhead to 2%.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
