[
https://issues.apache.org/jira/browse/YARN-6681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062309#comment-16062309
]
Naganarasimha G R commented on YARN-6681:
-----------------------------------------
[~daryn],
I went through all possible flows there was one flow where in {{refreshQueues}}
is called after deleting all the children of a parent Queue is not handled
properly but the catch is refresh itself fails. Apart from it in all other
flows its safe to return true for ParentQueue and false for LeafQueue for the
newly added method {{AbstractCSQueue.hasChildQueues}}.
So i am fine if you add it as part of this jira(preferable) or will fix it as
part of the new jira to fix the above mentioned issue(though this particular
change would be unrelated). Thoughts ?
> Eliminate double-copy of child queues in canAssignToThisQueue
> -------------------------------------------------------------
>
> Key: YARN-6681
> URL: https://issues.apache.org/jira/browse/YARN-6681
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.8.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: YARN-6681.2.branch-2.8.patch,
> YARN-6681.2.branch-2.patch, YARN-6681.2.trunk.patch,
> YARN-6681.branch-2.8.patch, YARN-6681.branch-2.patch, YARN-6681.trunk.patch
>
>
> 20% of the time in {{AbstractCSQueue#canAssignToThisQueue}} is spent
> performing two duplications a treemap of child queues into a list - once to
> test for null, second to see if it's empty. Eliminating the dups reduces the
> overhead to 2%.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
