[
https://issues.apache.org/jira/browse/YARN-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099146#comment-16099146
]
Yufei Gu commented on YARN-6610:
--------------------------------
Thanks [~templedf] for working on this. Some thoughts:
# I like what you did in method getResourceAsDominantValue().
# The parameter "boolean singleType" is not honored in method
{{compare(Resource clusterResource, Resource lhs, Resource rhs, boolean
singleType)}}.
# It may easily to go to this branch with multiple resources, say, only few
nodes have one type of resource and they went down, which causes resource
comparison less meaningful since {{compare(Resource lhs, Resource rhs)}} could
easily return 0. I assume we could use the similar algorithm in
{{compare(Resource clusterResource, Resource lhs, Resource rhs, boolean
singleType)}}.
{code}
if (isInvalidDivisor(clusterResource)) {
return this.compare(lhs, rhs);
}
{code}
# Do you mind add unit tests for {{compare(Resource clusterResource, Resource
lhs, Resource rhs, boolean singleType)}}?
# extra space in line "resource. The share ..."
> DominantResourceCalculator.getResourceAsValue() dominant param is no longer
> appropriate
> ---------------------------------------------------------------------------------------
>
> Key: YARN-6610
> URL: https://issues.apache.org/jira/browse/YARN-6610
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Critical
> Attachments: YARN-6610.001.patch
>
>
> The {{dominant}} param assumes there are only two resources, i.e. true means
> to compare the dominant, and false means to compare the subordinate. Now
> that there are _n_ resources, this parameter no longer makes sense.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
