[
https://issues.apache.org/jira/browse/YARN-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126090#comment-16126090
]
Yufei Gu commented on YARN-6610:
--------------------------------
Thanks [~templedf]'s patch and [~sunilg]'s review. The patch looks much better.
Some comments:
# Is it guaranteed that {{lhs}} and {{rhs}} get the same length? If not, we
need to handle the {{ArrayIndexOutOfBoundsException}} nicely. It seems OK to
ignore the exception.
# Still think unit tests for {{DominantResourceCalculator#compare()}} are worth
to do. I've searched around callers and callers of callers. Didn't find good
enough tests for this. Please let me know if they are there.
# Not sure how we can avoid this and merge two loops in [~sunilg]'s comment #3.
We could alway do further optimization, but it is premature without performance
tests and detailed performance analysis.
{code}
137 Arrays.sort(lhsShares);
138 Arrays.sort(rhsShares);
{code}
> DominantResourceCalculator.getResourceAsValue() dominant param is no longer
> appropriate
> ---------------------------------------------------------------------------------------
>
> Key: YARN-6610
> URL: https://issues.apache.org/jira/browse/YARN-6610
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Critical
> Attachments: YARN-6610.001.patch, YARN-6610.YARN-3926.002.patch,
> YARN-6610.YARN-3926.003.patch, YARN-6610.YARN-3926.004.patch
>
>
> The {{dominant}} param assumes there are only two resources, i.e. true means
> to compare the dominant, and false means to compare the subordinate. Now
> that there are _n_ resources, this parameter no longer makes sense.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
