[
https://issues.apache.org/jira/browse/YARN-6610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099257#comment-16099257
]
Wangda Tan commented on YARN-6610:
----------------------------------
Thanks [~templedf] for working on the patch and comments from
[~sunilg]/[~yufeigu].
Tried to review the patch, it is already outdated, I will do a detailed review
once the patch is updated. For one thing definitely need to be updated:
Existing impl creates and uses TreeSet for every compare operation, which could
be very slow according to testing of YARN-6788 (we expect another patch to
completely remove map operations in the code path of Resource). I suggest to
relook at the patch once we fill major performance gaps of YARN-3926 branch.
> DominantResourceCalculator.getResourceAsValue() dominant param is no longer
> appropriate
> ---------------------------------------------------------------------------------------
>
> Key: YARN-6610
> URL: https://issues.apache.org/jira/browse/YARN-6610
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Critical
> Attachments: YARN-6610.001.patch
>
>
> The {{dominant}} param assumes there are only two resources, i.e. true means
> to compare the dominant, and false means to compare the subordinate. Now
> that there are _n_ resources, this parameter no longer makes sense.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
