[ 
https://issues.apache.org/jira/browse/YARN-6600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123498#comment-16123498
 ] 

Sunil G commented on YARN-6600:
-------------------------------

Thanks [~rohithsharma]

Generally approach seems fine to me. Few comments
# In {{LeafQueue}}, I think {{getMaximumLifetime}} could be renamed as 
{{getMaximumApplicationLifetime}}
# Below comment seems not correct
{code}
645             // queue maximum lifetime is disabled
646             if (queueMaxLifetimeInSec > 0) {
{code}
# Newly added public api's need to be annotated with Unstable in 
{{AbstractYarnScheduler}} etc, correct?
# Javadoc could be added to YarnScheduler api's
# Could below entry to renamed as {{maximum-application-lifetime}}
{{public static final String MAXIMUM_LIFETIME_SUFFIX = "maximum-lifetime";}}
# IN reservation plan queue's, this feature is not yet supported as of today. 
Am i correct?
# Some commented code in {{TestApplicationLifetimeMonitor}}

> Enhance default lifetime of application at LeafQueue level.
> -----------------------------------------------------------
>
>                 Key: YARN-6600
>                 URL: https://issues.apache.org/jira/browse/YARN-6600
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: YARN-6600.01.patch, [YARN-6600] Extend lifetime to 
> scheduler Leaf Queue.pdf
>
>
> Setting timeout at LeafQueue level allows admin to control from bad apps 
> which uses most of the resources for all the time. 
> Example : Any application submitted to particular queue i.e QUEUE-1 should 
> not  run more than N hours. Even user set lifetime as N+1 hour, the 
> application will be killed after N hours. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to