[
https://issues.apache.org/jira/browse/YARN-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133702#comment-16133702
]
Vrushali C commented on YARN-6861:
----------------------------------
hi Rohith,
Thanks for the patch. Overall it looks good.
Some minor comments:
- I think the check style warnings about number of parameters can be ignored.
- the two whitespace warnings and check style warnings about redundant modifier
could be updated
- in TimelineReaderContext, in the constructor at L50 can we call the last
parameter as “doAsUser” or “subAppUser” instead of just user? Else we have
userId as second param and user as last param.
- could we print the scan.toJson after line 400 SubApplicationEntityReader
We should actually print out the scan anytime we create it since it will help
us in understanding what is being scanned. Later on, when things are running in
production, it’s hard to figure out what the start/stop rows were or if there
were any filters or if it got incorrectly configured. Not specific to this jira
but something I realized now.
- Just wondering, TimelineServiceV2 md file needs to have these new REST apis.
Will you add it later or in the documentation lira?
> Reader API for sub application entities
> ---------------------------------------
>
> Key: YARN-6861
> URL: https://issues.apache.org/jira/browse/YARN-6861
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: atsv2-subapp, yarn-5355-merge-blocker
> Attachments: YARN-6861-YARN-5355.001.patch,
> YARN-6861-YARN-5355.002.patch, YARN-6861-YARN-5355.003.patch
>
>
> YARN-6733 and YARN-6734 writes data into sub application table. There should
> be a way to read those entities.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
