[
https://issues.apache.org/jira/browse/YARN-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134132#comment-16134132
]
Varun Saxena commented on YARN-6861:
------------------------------------
Thanks [~rohithsharma] for the patch.
Few comments.
# As we are filling sub app UID, we should probably provide a UID REST endpoint
as well similar to other UID endpoints.
# SubApplicationEntityReader#fetchPartialColsFromInfoFamily and related methods
are not required. They can be reused from GenericEntityReader.
# You havent added javadoc for these REST endpoints like the previous ones but
as discussed offline, we can take a call on javadoc later on. So I am fine with
not adding it.
> Reader API for sub application entities
> ---------------------------------------
>
> Key: YARN-6861
> URL: https://issues.apache.org/jira/browse/YARN-6861
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: atsv2-subapp, yarn-5355-merge-blocker
> Attachments: YARN-6861-YARN-5355.001.patch,
> YARN-6861-YARN-5355.002.patch, YARN-6861-YARN-5355.003.patch,
> YARN-6861-YARN-5355.004.patch
>
>
> YARN-6733 and YARN-6734 writes data into sub application table. There should
> be a way to read those entities.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
