[
https://issues.apache.org/jira/browse/YARN-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165395#comment-16165395
]
Junping Du commented on YARN-7174:
----------------------------------
Thanks [~xgong] for reporting the issue and delivering a fix for it. I quickly
go through the patch, a couple of comments:
{noformat}
+ int maxRetries = 30;
+ long retryInterval = 1000;
{noformat}
Sounds like we were defining the default max retries and retry intervals inline
code, but better separated it out - may be too heavy to define in
YarnConfiguration but at least define it in front of class.
After adding two options to log CLI, we should add documentation change in yarn
log CLI page
(https://hadoop.apache.org/docs/r2.8.0/hadoop-yarn/hadoop-yarn-site/YarnCommands.html#logs).
Looks like we remove the verification of output of yarn log cli usage. Any
special reason to do this? If not, we should add it back to prevent
careless/unexpected change of usage output.
> Add retry logic in LogsCLI when fetch running application logs
> --------------------------------------------------------------
>
> Key: YARN-7174
> URL: https://issues.apache.org/jira/browse/YARN-7174
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-7174.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
