[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198881#comment-16198881 ]
Eric Yang commented on YARN-7202: --------------------------------- [~jianhe] I took another look at the code from patch 08, and I have answers for this question: {quote} confused, isn't this code not part of this patch ? I did clean before build. Can you try compile only this patch with the dependency removed? {quote} I refactored TestYarnNativeServices to move the configuration initializer code to ServiceTestUtils java class and move ServiceTestUtils java class to org/apache/hadoop/yarn/service/client/ServiceTestUtils. This was done to enhance the ability to reuse the utility class for YARN service setup for test cases. TestApiService extends ServiceTestUtils for mini yarn cluster setup. This is the reason that MiniHDFSCluster and MiniYARNCluster are both required dependencies for the test to run. The scope of the dependencies is set to "test". This is the reason that you were able to compile without the dependencies expressed, they are used during test phase. Hence, both exception throwing, and dependency expression are non-issues. Could you take another look at patch 08? I deleted patch 09 and 10 because the decision that we made are not correct in yesterday's meeting. > End-to-end UT for api-server > ---------------------------- > > Key: YARN-7202 > URL: https://issues.apache.org/jira/browse/YARN-7202 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Jian He > Assignee: Eric Yang > Attachments: YARN-7202.yarn-native-services.001.patch, > YARN-7202.yarn-native-services.002.patch, > YARN-7202.yarn-native-services.003.patch, > YARN-7202.yarn-native-services.004.patch, > YARN-7202.yarn-native-services.005.patch, > YARN-7202.yarn-native-services.006.patch, > YARN-7202.yarn-native-services.007.patch, > YARN-7202.yarn-native-services.008.patch, > YARN-7202.yarn-native-services.009.patch, > YARN-7202.yarn-native-services.010.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org