[ 
https://issues.apache.org/jira/browse/YARN-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735358#comment-13735358
 ] 

Sandy Ryza commented on YARN-899:
---------------------------------

The general approach and patch are looking good.  Some comments:

Do we need a QueueACLsManager separate from ApplicationACLsManager?  I.e. could 
we just have a reference to ResourceScheduler in ApplicationACLsManager and 
check access based on the queue name there?

The LOG.debugs in the scheduler checkAccess methods should be surrounded by 
isDebugEnabled()

Filed YARN-1052 for moving submit ACLs outside the scheduler. 
                
> Get queue administration ACLs working
> -------------------------------------
>
>                 Key: YARN-899
>                 URL: https://issues.apache.org/jira/browse/YARN-899
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.1.0-beta
>            Reporter: Sandy Ryza
>            Assignee: Xuan Gong
>         Attachments: YARN-899.1.patch, YARN-899.2.patch, YARN-899.3.patch, 
> YARN-899.4.patch
>
>
> The Capacity Scheduler documents the 
> yarn.scheduler.capacity.root.<queue-path>.acl_administer_queue config option 
> for controlling who can administer a queue, but it is not hooked up to 
> anything.  The Fair Scheduler could make use of a similar option as well.  
> This is a feature-parity regression from MR1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to