[
https://issues.apache.org/jira/browse/YARN-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13777799#comment-13777799
]
Zhijie Shen commented on YARN-899:
----------------------------------
1. Is the following code necessary?
{code}
+ System.out.println(callerUGI);
{code}
2. Why not defining checkAccess in YarnScheduler? I saw other ACL related
method is defined there as well.
{code}
+ boolean checkAccess(UserGroupInformation callerUGI,
+ QueueACL acl, String queueName);
{code}
3. checkViewAccess is used in getApplications and getApplicationReport, does
"||" mean the user doesn't need to have the access to the application whenever
it has the access to the queue?
{code}
- private boolean checkAccess(UserGroupInformation callerUGI, String owner,
- ApplicationAccessType operationPerformed, ApplicationId applicationId) {
+ private boolean checkViewAccess(UserGroupInformation callerUGI, String owner,
+ ApplicationAccessType operationPerformed,
+ RMApp application) {
return applicationsACLsManager.checkAccess(callerUGI, operationPerformed,
- owner, applicationId);
+ owner, application.getApplicationId())
+ || queueACLsManager.checkAccess(callerUGI, QueueACL.ADMINISTER_QUEUE,
+ application.getQueue());
{code}
> Get queue administration ACLs working
> -------------------------------------
>
> Key: YARN-899
> URL: https://issues.apache.org/jira/browse/YARN-899
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 2.1.0-beta
> Reporter: Sandy Ryza
> Assignee: Xuan Gong
> Attachments: YARN-899.1.patch, YARN-899.2.patch, YARN-899.3.patch,
> YARN-899.4.patch, YARN-899.5.patch, YARN-899.5.patch, YARN-899.6.patch,
> YARN-899.7.patch, YARN-899.8.patch
>
>
> The Capacity Scheduler documents the
> yarn.scheduler.capacity.root.<queue-path>.acl_administer_queue config option
> for controlling who can administer a queue, but it is not hooked up to
> anything. The Fair Scheduler could make use of a similar option as well.
> This is a feature-parity regression from MR1.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
