[
https://issues.apache.org/jira/browse/YARN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223824#comment-16223824
]
Wangda Tan commented on YARN-4511:
----------------------------------
[~haibo.chen],
Haven't reviewed all details of the patch, but the latest patch looks much
cleaner than previous one. I took a closer look at SchedulerNode.
Few comments:
- {{assert}} in the main code (Such as SchedulerNode) will be removed at
runtime. Do you want to throw exception instead?
- Moving following statements:
{code}
// do not update allocated containers until the resources of the
// container are released because we need to check if we need
// to update resourceAllocatedPendingLaunch in case the container
// has not been launched on the node.
allocatedContainers.remove(containerId);
numGuaranteedContainers--;
{code}
To {{guaranteedContainerResourceReleased}}? And same for the
{{opportunisticContainerResourceReleased}}
- Duplicated isDebugEnabled:
{code}
if (LOG.isDebugEnabled()) {
if (LOG.isDebugEnabled()) {
{code}
Please proceed if you get a +1 from other committer. (Since I haven't reviewed
all other logics)
+ [~asuresh] in case he wants to take a look.
> Common scheduler changes supporting scheduler-specific implementations
> ----------------------------------------------------------------------
>
> Key: YARN-4511
> URL: https://issues.apache.org/jira/browse/YARN-4511
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Haibo Chen
> Attachments: YARN-4511-YARN-1011.00.patch,
> YARN-4511-YARN-1011.01.patch, YARN-4511-YARN-1011.02.patch,
> YARN-4511-YARN-1011.03.patch, YARN-4511-YARN-1011.04.patch,
> YARN-4511-YARN-1011.05.patch, YARN-4511-YARN-1011.06.patch,
> YARN-4511-YARN-1011.07.patch, YARN-4511-YARN-1011.08.patch,
> YARN-4511-YARN-1011.09.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
