[
https://issues.apache.org/jira/browse/YARN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225973#comment-16225973
]
Haibo Chen commented on YARN-4511:
----------------------------------
Thanks [~leftnoteasy] for the review!
bq. assert in the main code (Such as SchedulerNode) will be removed at runtime.
Do you want to throw exception instead?
The assert is meant mainly for documentation purpose. I'll replace them with
throw exception instead.
bq. Moving following statements to guaranteedContainerResourceReleased?
Good point. Will do that and rename it to guaranteedContainerReleased given its
semantics are changed, and likewise for guaranteedContainerAllocated.
> Common scheduler changes supporting scheduler-specific implementations
> ----------------------------------------------------------------------
>
> Key: YARN-4511
> URL: https://issues.apache.org/jira/browse/YARN-4511
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Haibo Chen
> Attachments: YARN-4511-YARN-1011.00.patch,
> YARN-4511-YARN-1011.01.patch, YARN-4511-YARN-1011.02.patch,
> YARN-4511-YARN-1011.03.patch, YARN-4511-YARN-1011.04.patch,
> YARN-4511-YARN-1011.05.patch, YARN-4511-YARN-1011.06.patch,
> YARN-4511-YARN-1011.07.patch, YARN-4511-YARN-1011.08.patch,
> YARN-4511-YARN-1011.09.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
