[ 
https://issues.apache.org/jira/browse/YARN-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283556#comment-16283556
 ] 

Jason Lowe commented on YARN-7625:
----------------------------------

Thanks for the patch!

Get methods that have side effects are a bit less than ideal.  Would it make 
more sense to update the metrics when the values are calculated rather than 
when they are retrieved?  Due to out-of-band heartbeats, it's not unusual for 
the nodemanager to generate a node status more often than the 
ContainersMonitorImpl and NodeResourceMonitorImpl will calculate new values.  
Similarly if the admin has configured a large node heartbeat interval then the 
metric is only updated when the node heartbeats rather than when new values 
have been calculated by the monitoring code.


> Expose NM node/containers resource utilization in JVM metrics
> -------------------------------------------------------------
>
>                 Key: YARN-7625
>                 URL: https://issues.apache.org/jira/browse/YARN-7625
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: YARN-7625.001.patch
>
>
> YARN-4055 adds node resource utilization to NM, we should expose these info 
> in NM metrics, it helps in following cases:
> # Users want to check NM load in NM web UI or via rest API
> # Provide the API to further integrated to the new yarn UI, to display NM 
> load status



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to