[ 
https://issues.apache.org/jira/browse/YARN-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283900#comment-16283900
 ] 

Weiwei Yang commented on YARN-7625:
-----------------------------------

Hi [~jlowe]

I agree. To ensure the metrics be accurate, it should be published when its 
value gets updated. This needs to be done in {{ContainersMonitorImpl}} and 
{{NodeResourceMonitorImpl}}. I just uploaded v2 patch, with following changes
# Moved the publish metrics code to {{ContainersMonitorImpl}} and 
{{NodeResourceMonitorImpl}}, they publish the metrics in each monitor interval 
once utilization updated
# Added {{NodeManagerMetrics}} into node manager {{Context}}, so it can be 
accessed in monitors
# Added 2 UT to test metrics update in both {{ContainersMonitorImpl}} and 
{{NodeResourceMonitorImpl}}

Please help to review, thanks.

> Expose NM node/containers resource utilization in JVM metrics
> -------------------------------------------------------------
>
>                 Key: YARN-7625
>                 URL: https://issues.apache.org/jira/browse/YARN-7625
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: YARN-7625.001.patch
>
>
> YARN-4055 adds node resource utilization to NM, we should expose these info 
> in NM metrics, it helps in following cases:
> # Users want to check NM load in NM web UI or via rest API
> # Provide the API to further integrated to the new yarn UI, to display NM 
> load status



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to