[
https://issues.apache.org/jira/browse/YARN-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286035#comment-16286035
]
Jason Lowe commented on YARN-7625:
----------------------------------
Thanks for updating the patch! It looks a lot better.
Just one small nit, as I'm not a fan of explicit sleeps in unit tests. Rather
than sleeping for a full duration and then checking I'd rather see the tests
leverage Mockito's verify-with-timeout feature, e.g.:
{code}
Mockito.verify(spyContext, timeout(500)).getNodeManagerMetrics();
{code}
That way the test doesn't have to burn the full timeout every time.
> Expose NM node/containers resource utilization in JVM metrics
> -------------------------------------------------------------
>
> Key: YARN-7625
> URL: https://issues.apache.org/jira/browse/YARN-7625
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Attachments: YARN-7625.001.patch, YARN-7625.002.patch,
> YARN-7625.003.patch
>
>
> YARN-4055 adds node resource utilization to NM, we should expose these info
> in NM metrics, it helps in following cases:
> # Users want to check NM load in NM web UI or via rest API
> # Provide the API to further integrated to the new yarn UI, to display NM
> load status
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
