[
https://issues.apache.org/jira/browse/YARN-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299168#comment-16299168
]
Robert Kanter commented on YARN-7557:
-------------------------------------
Thanks for the patch [~grepas]. A few comments:
# After the {{Matcher}}, instead of a series of if statements to check for
{{MEMORY_MB}} and {{VCORES}} on every match, I think we could unify and save
the checks by simply adding everything to the {{others}} {{HashMap}}. After
all that's done, we can simply do a lookup in {{others}} for {{MEMORY_MB}} and
{{VCORES}}, and remove them.
# {{A_CUSTOM_RESOURCE}} should be used in the XML in
{{getConfigurationInputStream}} instead of the String {{a-custom-resource}}
# I don't have all of the context on this, but it sounds like we should be
deprecating
{{RM_SCHEDULER_INCREMENT_ALLOCATION_MB}}/{{yarn.scheduler.increment-allocation-mb}}
and
{{RM_SCHEDULER_INCREMENT_ALLOCATION_VCORES}}/{{yarn.scheduler.increment-allocation-vcores}},
right?
> It should be possible to specify resource types in the fair scheduler
> increment value
> -------------------------------------------------------------------------------------
>
> Key: YARN-7557
> URL: https://issues.apache.org/jira/browse/YARN-7557
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Affects Versions: 3.0.0-beta1
> Reporter: Daniel Templeton
> Assignee: Gergo Repas
> Priority: Critical
> Attachments: YARN-7557.000.patch, YARN-7557.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
