[ https://issues.apache.org/jira/browse/YARN-6619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328069#comment-16328069 ]
Konstantinos Karanasos commented on YARN-6619: ---------------------------------------------- Thanks for the patch, [~asuresh]. Couple of comments: * Let's add a new {{registerAM}} API to the {{AMRMClient}} that takes a map from tag sets to constraints. This way we can reserve the {{addPlacementConstraint}} API for cases that a client wants to update the constraints. By extending the {{registerAM}} method, we don't need to worry about the client calling the {{addPlacementConstraint}} before calling the {{registerAM}}. * I think it's more precise to keep the {{addConstraint}} method to its current name (no "default"). If a scheduling request wants to override those, it's fine, but I wouldn't call them default. * If there are no tags, do we still associate a constraint with an empty tag? * {{addToOutstandingSchedulingRequests()}}: let's put the long if statement in a new method. Nit: in AMRMClientAsync, "called when the RM has rejected a Scheduling Requests" (let's remove either the a or the plural). > AMRMClient Changes to use the PlacementConstraint and SchcedulingRequest > objects > -------------------------------------------------------------------------------- > > Key: YARN-6619 > URL: https://issues.apache.org/jira/browse/YARN-6619 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Arun Suresh > Assignee: Arun Suresh > Priority: Major > Attachments: YARN-6619-YARN-6592.001.patch, > YARN-6619-YARN-6592.002.patch > > > Opening this JIRA to track changes needed in the AMRMClient to incorporate > the PlacementConstraint and SchedulingRequest objects -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org