[ 
https://issues.apache.org/jira/browse/YARN-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341468#comment-16341468
 ] 

Arun Suresh commented on YARN-7822:
-----------------------------------

[~cheersyang], Thanks for working on this..

Couple of comments:
* I see a TODO stating that nested AND / OR is not supported. Given that the 
the children of OR / AND can take any AbstractConstraint, it should be possible 
right ?
* In your testcases, I see references to {{FiCaSchedulerNode}}. Can you replace 
with SchedulerNode. We would like to keep this module as scheduler agnostic as 
possible.
* Can you also add a testcase to the {{TestPlacementProcessor}} to validate an 
end-2-end scenario ?

I was thinking we make changes to the DistributedShell as well. Should we do it 
here ? or I am open to doing it in another JIRA.





> Constraint satisfaction checker support for composite OR and AND constraints
> ----------------------------------------------------------------------------
>
>                 Key: YARN-7822
>                 URL: https://issues.apache.org/jira/browse/YARN-7822
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Weiwei Yang
>            Priority: Major
>         Attachments: YARN-7822-YARN-6592.001.patch
>
>
> JIRA to track changes to {{PlacementConstraintsUtil#canSatisfyConstraints}} 
> handle OR and AND Composite constaints



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to