[ 
https://issues.apache.org/jira/browse/YARN-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342976#comment-16342976
 ] 

Arun Suresh commented on YARN-7822:
-----------------------------------

Thanks for updating the patch [~cheersyang].

I was just thinking - You should maybe try to implement the checker as a 
{{PlacementConstraint.Visitor}}.
But yeah, for simple AND/OR, it might be an over-kill, so once we get to nested 
AND/OR, we can use a Visitor.

Thanks for the adding the new tests.
+1 pending jenkins


> Constraint satisfaction checker support for composite OR and AND constraints
> ----------------------------------------------------------------------------
>
>                 Key: YARN-7822
>                 URL: https://issues.apache.org/jira/browse/YARN-7822
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Weiwei Yang
>            Priority: Major
>         Attachments: YARN-7822-YARN-6592.001.patch, 
> YARN-7822-YARN-6592.002.patch, YARN-7822-YARN-6592.003.patch
>
>
> JIRA to track changes to {{PlacementConstraintsUtil#canSatisfyConstraints}} 
> handle OR and AND Composite constaints



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to