[ https://issues.apache.org/jira/browse/YARN-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343108#comment-16343108 ]
Weiwei Yang commented on YARN-7822: ----------------------------------- Thanks [~asuresh] {quote}Maybe instead of stating in the doc that "we do not allow more than max target tags at the node", we should re-word it as "placement will be made only if, at the time evaluation, only UPTO a max of target tags exist on the node {quote} Thanks for the explanation, I don't fully get it but I think this is something specifically related to the code. In this case, I agree we should make sure the doc up-to-date. Just took a look at the doc in YARN-7780, it still states like {noformat} For example, \{@code cardinality(NODE, 3, 10, "zk")} is satisfied on nodes where there are no less than 3 allocations with tag "zk" and no more than 10. {noformat} v4 patch uploaded, fixed checkstyle and removed FIXME. The failed test case is not related to this patch, it runs cleanly on my local env. Please take a look. Thanks. > Constraint satisfaction checker support for composite OR and AND constraints > ---------------------------------------------------------------------------- > > Key: YARN-7822 > URL: https://issues.apache.org/jira/browse/YARN-7822 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Arun Suresh > Assignee: Weiwei Yang > Priority: Major > Attachments: YARN-7822-YARN-6592.001.patch, > YARN-7822-YARN-6592.002.patch, YARN-7822-YARN-6592.003.patch, > YARN-7822-YARN-6592.004.patch > > > JIRA to track changes to {{PlacementConstraintsUtil#canSatisfyConstraints}} > handle OR and AND Composite constaints -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org