[ 
https://issues.apache.org/jira/browse/YARN-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343437#comment-16343437
 ] 

Weiwei Yang commented on YARN-7840:
-----------------------------------

Hi [~Naganarasimha]

Thanks for working on this. The patch is pretty straightforward, I just have 
some minor comments
 # Can we add the prefix to \{{NodeAttributePBImpl#toString}}?
 # {\{NodeAttribute}} line 41: can we change text "Node Prefix" to "Node 
attribute prefix"
 # There seems to be a trailing whitespace in the patch, line 22

Thanks

> Update PB for prefix support of node attributes
> -----------------------------------------------
>
>                 Key: YARN-7840
>                 URL: https://issues.apache.org/jira/browse/YARN-7840
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Naganarasimha G R
>            Priority: Blocker
>         Attachments: YARN-7840-YARN-3409.001.patch
>
>
> We need to support prefix (namespace) for node attributes, this will add the 
> flexibility to provide ability to do proper ACL, avoid naming conflicts etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to