[ 
https://issues.apache.org/jira/browse/YARN-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345034#comment-16345034
 ] 

Sunil G commented on YARN-7840:
-------------------------------

Thanks [~Naganarasimha]

One comment:

{{NodeAttributeTypeProto}} have the type info which is STRING by default. I 
think we can have type wrapped in value. This may be better because type is 
only depending on the value part of an attribute, hence need not have to be in 
upper layer. This is similar to resource and its unit. Suggestions?
{code:java}
message NodeAttributeProto {
optional string attributePrefix = 1;
optional string attributeName = 2;
optional NodeAttributeValueProto attributeValue = 3;
}

message NodeAttributeValueProto {
optional string attributeValue = 1;
optional NodeAttributeTypeProto attributeType = 2 [default = STRING];
}{code}

> Update PB for prefix support of node attributes
> -----------------------------------------------
>
>                 Key: YARN-7840
>                 URL: https://issues.apache.org/jira/browse/YARN-7840
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Naganarasimha G R
>            Priority: Blocker
>         Attachments: YARN-7840-YARN-3409.001.patch, 
> YARN-7840-YARN-3409.002.patch
>
>
> We need to support prefix (namespace) for node attributes, this will add the 
> flexibility to provide ability to do proper ACL, avoid naming conflicts etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to