[ 
https://issues.apache.org/jira/browse/YARN-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346002#comment-16346002
 ] 

Weiwei Yang commented on YARN-7840:
-----------------------------------

Hi [~Naganarasimha]

Can you please take a look at [~sunilg] and [~bibinchundatt]'s comments?
I think [~sunilg] is raising up a good point, since the type is only valid when 
there is a value, it would be good to wrap the type to value proto. Which I 
think it could be helpful to handle the case when a node attribute is added 
without a value (like a label). I also agree to [~bibinchundatt] to add 
[default=""] to the attributePrefix since it is optional.

Thanks

> Update PB for prefix support of node attributes
> -----------------------------------------------
>
>                 Key: YARN-7840
>                 URL: https://issues.apache.org/jira/browse/YARN-7840
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Naganarasimha G R
>            Priority: Blocker
>         Attachments: YARN-7840-YARN-3409.001.patch, 
> YARN-7840-YARN-3409.002.patch
>
>
> We need to support prefix (namespace) for node attributes, this will add the 
> flexibility to provide ability to do proper ACL, avoid naming conflicts etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to