[ https://issues.apache.org/jira/browse/YARN-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372279#comment-16372279 ]
Naganarasimha G R commented on YARN-6858: ----------------------------------------- Thanks for the Comments [~bibinchundatt], Have incorporated the changes for all your comments but had few points to mention {quote}Had an offline discussion with Sunil G we thought to using separate store for Nodelabels and Attributes enabled separately {quote} Even during my initial discussions with Sunil we had concluded on the same approach. generalize the store api and have different store for Attribute so that its compatible and does not break on rollback. {quote}Param name mismatch in following method {quote} I believe i had missed a param, but param names were same. Please correct me if i am wrong. {quote}Currently manager doesnt provide a way to filter out nodes of type central, distributed type. {quote} I have taken care of it by providing a set of prefixes in the existing interface to get the clusterAttributes. Please check whether its sufficient. > Attribute Manager to store and provide the attributes in RM > ----------------------------------------------------------- > > Key: YARN-6858 > URL: https://issues.apache.org/jira/browse/YARN-6858 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, capacityscheduler, client > Reporter: Naganarasimha G R > Assignee: Naganarasimha G R > Priority: Major > Attachments: YARN-6858-YARN-3409.001.patch, > YARN-6858-YARN-3409.002.patch, YARN-6858-YARN-3409.003.patch, > YARN-6858-YARN-3409.004.patch, YARN-6858-YARN-3409.005.patch, > YARN-6858-YARN-3409.006.patch, YARN-6858-YARN-3409.007.patch > > > Similar to CommonNodeLabelsManager we need to have a centralized manager for > Node Attributes too. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org