[
https://issues.apache.org/jira/browse/YARN-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361971#comment-16361971
]
Sunil G commented on YARN-6858:
-------------------------------
Thanks [~Naganarasimha] . In general patch looks fine to me.
Some Minor nits.
# {{RMLabel}} name seems a bit confusing. Its a property or a tag either
indicating to a set of nodes or one node. So *GenericTagInfo* or something
similar may be better. Because it consolidates all general properties
associated with a tag (could be partition/label/attribute)
# RMLabel#getResource is not cloning incoming resource when its created. So if
this is a read-only param, and usage of the resource is lesser, we need not
have to have a copy. Otherwise its better to do a clone. (if more op is on this
getter, i prefer not clone and it associates a bit of performance cost)
# RMAttributeNodeLabel: could it be just RMNodeAttribute ?
# In RMAttributeNodeLabel, do we need to make that Set concurrent ? I can see
that its used as a ConcurrentHashMap where it is consumed, but it could be
referenced for metrics/REST rt. Are we planning to consume these objects via
only Manager?
# {{public Map<NodeAttribute, AttributeValue> getAttributesForNode}} is a bit
confusing. However I can see the intent. For scheduler, value also is needed to
do necessary type conversions. However for many metrics, we dont need value. So
we can have another *getAttributesForNode* which returns a list of
*NodeAttribute* alone too.
> Attribute Manager to store and provide the attributes in RM
> -----------------------------------------------------------
>
> Key: YARN-6858
> URL: https://issues.apache.org/jira/browse/YARN-6858
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, capacityscheduler, client
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Major
> Attachments: YARN-6858-YARN-3409.001.patch,
> YARN-6858-YARN-3409.002.patch, YARN-6858-YARN-3409.003.patch,
> YARN-6858-YARN-3409.004.patch, YARN-6858-YARN-3409.005.patch
>
>
> Similar to CommonNodeLabelsManager we need to have a centralized manager for
> Node Attributes too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
