[ 
https://issues.apache.org/jira/browse/YARN-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362108#comment-16362108
 ] 

Bibin A Chundatt commented on YARN-6858:
----------------------------------------

Thanks [~Naganarasimha] for patch

Few comments.

{code}
107         initNodeLabelStore(getConfig());
  protected void initNodeLabelStore(Configuration conf) throws Exception {
    // TODO to generalize and make use of the FileSystemNodeLabelsStore
  }
{code}
# Had an offline discussion with Sunil G we thought to using separate store for 
 Nodelabels and Attributes enabled separately.
# Event type used for registration is wrong should be 
{code}
112         if (null != dispatcher) {
113           dispatcher.register(NodeLabelsStoreEventType.class,
114               new ForwardingEventHandler());
115         }
{code}
# Param name mismatch in following method
{code}
  /**
   * @param nodeAttributeMappings
   * @param newAttributesToBeAdded
   * @return Map<String, Map<NodeAttribute, AttributeValue>>, node -> Map(
   *         NodeAttribute -> AttributeValue)
   * @throws IOException, on invalid mapping in the current request or against
   *           already existing NodeAttributes.
   */
  protected Map<String, Map<NodeAttribute, AttributeValue>> validate(
      Map<String, Set<NodeAttribute>> nodeAttributeMapping,
      Map<NodeAttribute, RMAttributeNodeLabel> newAttributesToBeAdded,
      boolean isRemoveOperation) throws IOException
{code}
# Event Type wrong in {{ForwardingEventHandler}}
{code}
ForwardingEventHandler<NodeLabelsStoreEvent> type is wrong
{code}
# InternalUpdateLabelsOnNodes rename to internalUpdateAttributesOnNodes
# Currently manager doesnt provide a way to filter out nodes of type central, 
distributed type. I think we should provide that too

> Attribute Manager to store and provide the attributes in RM
> -----------------------------------------------------------
>
>                 Key: YARN-6858
>                 URL: https://issues.apache.org/jira/browse/YARN-6858
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, capacityscheduler, client
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Major
>         Attachments: YARN-6858-YARN-3409.001.patch, 
> YARN-6858-YARN-3409.002.patch, YARN-6858-YARN-3409.003.patch, 
> YARN-6858-YARN-3409.004.patch, YARN-6858-YARN-3409.005.patch, 
> YARN-6858-YARN-3409.006.patch
>
>
> Similar to CommonNodeLabelsManager we need to have a centralized manager for 
> Node Attributes too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to