Eric Payne commented on YARN-4781:

Thanks a lot for the review [~sunilg].
{quote} my concern is over case where we need to worry about priority with 
FairOrdering. Both are kind of mutually exclusive feature to me.

we need to ensure that FairOrdering + USERLIMIT_FIRST is the combination
It appears that the capacity scheduler's FairOrderingPolicy ignores priority. 
That is why I did not consider it in the {{TAFairOrderingComparator.}} Having 
said that, I am fine with adding an additional check to ensure that 
USERLIMIT_FIRST is set before setting the {{TAFairOrderingComparator}}
{quote}could we use Fair plugin instead of FifoIntraQueuePreemptionPlugin, and 
make an abstract class to move all common code. Then Fair plugin could be auto 
chosen based on ordering policy selected
I feel that this would add unnecessary complexity. I think restricting the 
changes to the comparator is a cleaner approach.


> Support intra-queue preemption for fairness ordering policy.
> ------------------------------------------------------------
>                 Key: YARN-4781
>                 URL: https://issues.apache.org/jira/browse/YARN-4781
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Major
>         Attachments: YARN-4781.001.patch
> We introduced fairness queue policy since YARN-3319, which will let large 
> applications make progresses and not starve small applications. However, if a 
> large application takes the queue’s resources, and containers of the large 
> app has long lifespan, small applications could still wait for resources for 
> long time and SLAs cannot be guaranteed.
> Instead of wait for application release resources on their own, we need to 
> preempt resources of queue with fairness policy enabled.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to