[ 
https://issues.apache.org/jira/browse/YARN-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402224#comment-16402224
 ] 

Zian Chen commented on YARN-8016:
---------------------------------

Hi [~leftnoteasy] , when I'm doing the patch refactor, I realize an issue in 
comment No.3 which suggests move getQueueMappingEntity out from 
CapacitySchedulerConfiguration. This actually has some reason here. 
 # we actually put both getQueueMappingEntity and setQueueMappingEntity inside 
CapacitySchedulerConfiguration cause these two methods are used to set 
properties for CapacitySchedulerConfiguration, not a general setter and getter 
method. If we move out of CapacitySchedulerConfiguration, like into 
QueuePlacementRuleUtils, the setting will not take effect for the conf.
 # UserGroupMappingPlacementRule is also put its getQueueMappings and 
setQueueMappings inside CapacitySchedulerConfiguration too.

Let's me put it inside CapacitySchedulerConfiguration for now and make 
everything work. Then we can discuss further if you have better idea for this, 
Thanks!

> Refine PlacementRule interface and add a app-name queue mapping rule as an 
> example
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-8016
>                 URL: https://issues.apache.org/jira/browse/YARN-8016
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Zian Chen
>            Assignee: Zian Chen
>            Priority: Major
>         Attachments: YARN-8016.001.patch
>
>
> After YARN-3635/YARN-6689, PlacementRule becomes a common interface which can 
> be used by scheduler and can be dynamically updated by scheduler according to 
> configs. There're some other works. 
> - There's no way to initialize PlacementRule.
> - No example of PlacementRule except the user-group mapping one.
> This JIRA is targeted to refine PlacementRule interfaces and add another 
> PlacementRule example.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to