[
https://issues.apache.org/jira/browse/YARN-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405070#comment-16405070
]
Wangda Tan commented on YARN-8016:
----------------------------------
Thanks [~Zian Chen] for the update, I'm fine with keep methods in
CapacitySchedulerConfiguration, for the second comment:
bq. The second question is the test case for chain of placement rules. I
understand your suggestion is to like set up some cases which will let the
switch case condition inside CS#updatePlacementRules so that the case failed
with previous placement rule can still handle by the second placement rule, for
example, AppNamePlacementRule. However, the logic here is kind of strange, if
one case can enter into the first switch case which is UserGroupPlcaementRule,
then it means the mapping related to the case is for UserGroupMappingRule, here
in the switch case, we just initialize the rule based on the mapping, not doing
the getPlacementForApp method call, so the condition like we set user1 for the
mapping but we actually use user2 to consume the mapping will not happen cause
this is another story for getPlacementForApp related calls, not
updatePlacementRules.
IIRC, {{updatePlacementRules}} is invoked when reinitialize queue
configurations. And {{getPlacementForApp}} is invoked when do per-app queue
mapping. I'm not sure about what does your previous comment mean, could you
share any example?
Apart from UT failure, could u also take care of ASF license warning / findbugs
warning.
> Refine PlacementRule interface and add a app-name queue mapping rule as an
> example
> ----------------------------------------------------------------------------------
>
> Key: YARN-8016
> URL: https://issues.apache.org/jira/browse/YARN-8016
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Zian Chen
> Assignee: Zian Chen
> Priority: Major
> Attachments: YARN-8016.001.patch, YARN-8016.002.patch
>
>
> After YARN-3635/YARN-6689, PlacementRule becomes a common interface which can
> be used by scheduler and can be dynamically updated by scheduler according to
> configs. There're some other works.
> - There's no way to initialize PlacementRule.
> - No example of PlacementRule except the user-group mapping one.
> This JIRA is targeted to refine PlacementRule interfaces and add another
> PlacementRule example.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
