[
https://issues.apache.org/jira/browse/YARN-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634549#comment-16634549
]
Haibo Chen commented on YARN-8644:
----------------------------------
Thanks [~snemeth] for the patch! I am not sure if moving methods into
AppCreationTestHelper helps reduce complexity. Besides moving the methods, now
we have a new Builder class, and more parameters to pass around. I'd suggest
we get rid of AppCreationTestHelper changes. Additionally, changes like "r =
func(); return r;" => "return func()" are not technically necessary. Can we
revert those two changes so that the patch is smaller and more focused?
> Make RMAppImpl$FinalTransition more readable + add more test coverage
> ---------------------------------------------------------------------
>
> Key: YARN-8644
> URL: https://issues.apache.org/jira/browse/YARN-8644
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-8644.001.patch, YARN-8644.002.patch,
> YARN-8644.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
