[
https://issues.apache.org/jira/browse/YARN-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636391#comment-16636391
]
Szilard Nemeth commented on YARN-8644:
--------------------------------------
Thanks [~haibochen] for another round of review.
1. Good point, moved the line to that method.
2. Most of the checkstyle issues were already reverted. The only remaining
changes in the test class are changing method visibilities to more restrictive
and removing superfluous type parameters from generic collections. I guess I
can keep these changes as it does not bother checkstyle.
3. Very good point. There were some overlaps, indeed.
- assertStartTimeSet / assertTimesAtFinish methods were invoked already.
Extended assertStartTimeSet to assert whether the app's start time is after the
testcase's start time, so I added the testcaseStartTime field again to the test
class and initialized in the setup method before every testcase.
- The rest of verifyAppBeforeFinishEvent / verifyAppAfterFinishEvent is
required, the overlaps only covered the asserts related to app start time / app
end time.
4. The previous one was a quick and easy way to address the problem, my current
solution is way more robust, see the newly added waitForAppAttemptState method.
Please note that this is very similar to the methods that are in MockRM, but I
could not extend that class as it has its own event handlers which is pretty
different than TestRMAppTransitions, where we don't use MockRM, but just the
event handlers. Hope this is clear.
> Make RMAppImpl$FinalTransition more readable + add more test coverage
> ---------------------------------------------------------------------
>
> Key: YARN-8644
> URL: https://issues.apache.org/jira/browse/YARN-8644
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-8644.001.patch, YARN-8644.002.patch,
> YARN-8644.003.patch, YARN-8644.004.patch, YARN-8644.005.patch,
> YARN-8644.006.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
