[
https://issues.apache.org/jira/browse/YARN-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636212#comment-16636212
]
Haibo Chen commented on YARN-8644:
----------------------------------
Thanks [~snemeth] for the update. A few follow-up comments:
1) we can move "app.logAggregationStartTime = app.systemClock.getTime();" to
handleAppFinished() too.
2) We can probably revert the changes that fix checkstyle issues in lines
unrelated to this patch, so that the patch can be leaner.
3) The test unit test "testFinalTransition" may have been done as part of the
existing tests (The ones that send ATTEMPT_FINISHED event). Can you check if we
can modify existing test(s) instead?
4) I see the way handleAppAttemptFollowsAppRemoval() is implemented is due to
the indetermistic nature of event ordering. Can we check if we can wait for
APP_ATTEMPT_ADDED event before finishing the attempt?
> Make RMAppImpl$FinalTransition more readable + add more test coverage
> ---------------------------------------------------------------------
>
> Key: YARN-8644
> URL: https://issues.apache.org/jira/browse/YARN-8644
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-8644.001.patch, YARN-8644.002.patch,
> YARN-8644.003.patch, YARN-8644.004.patch, YARN-8644.005.patch,
> YARN-8644.006.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
