[
https://issues.apache.org/jira/browse/YARN-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646140#comment-16646140
]
Sunil Govindan commented on YARN-8836:
--------------------------------------
Thanks [~cheersyang] for the patch.
Few comments:
# In {{ResourcePBImpl}}, you also need to change mergeLocalToBuilder, so that
this PBImpl can create ResourceInformationProto by considering the new tags and
attributes. Could you please check whether it is needed?
# In {{convertStringStringMapProtoListToMap}}, any checked is needed to ensure
key is not null?
# In ResourceInformation#equals, could we avoid checking tags and attributes
in case if its empty or null?
# In resource-types-5.xml, could we add some resources with tags as well, and
have a test based on same ?
> Add tags and attributes in resource definition
> ----------------------------------------------
>
> Key: YARN-8836
> URL: https://issues.apache.org/jira/browse/YARN-8836
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-8836.001.patch, YARN-8836.002.patch
>
>
> We need a more descriptive way to describe resources such as volume, a single
> value is not enough. Hence propose to add tags and attributes in resource
> definition, both are optional fields. Tags are the resource labels used to
> group resource by character; attributes are key-value pairs to carry
> arbitrary information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
