[
https://issues.apache.org/jira/browse/YARN-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649679#comment-16649679
]
Weiwei Yang commented on YARN-8836:
-----------------------------------
Hi [~sunilg]
Thanks for the comments, really good ones.
{quote}In {{ResourcePBImpl}}, you also need to change mergeLocalToBuilder
{quote}
Yes, that is necessary, otherwise when we convert resource information back to
protobuf message, tags and attributes will be missing. I have done that in v3
patch, also I added test case in \{{TestResourcePBImpl}} to cover that, thanks
for correcting this.
{quote}any checked is needed to ensure key is not null?
{quote}
Better to have that check, added.
{quote}In ResourceInformation#equals, could we avoid checking tags and
attributes in case if its empty or null?
{quote}
I don't think that is necessary, as AbstractSet or AbstractMap already
implemented that, I think we are fine.
{quote}In resource-types-5.xml, could we add some resources with tags as well,
and have a test based on same
{quote}
Yes, added that, also added a test case in
\{{TestResourcePBImpl#testParsingResourceTags}}.
Please take a look, thanks!
> Add tags and attributes in resource definition
> ----------------------------------------------
>
> Key: YARN-8836
> URL: https://issues.apache.org/jira/browse/YARN-8836
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-8836.001.patch, YARN-8836.002.patch,
> YARN-8836.003.patch
>
>
> We need a more descriptive way to describe resources such as volume, a single
> value is not enough. Hence propose to add tags and attributes in resource
> definition, both are optional fields. Tags are the resource labels used to
> group resource by character; attributes are key-value pairs to carry
> arbitrary information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
