[ 
https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646831#comment-16646831
 ] 

Szilard Nemeth commented on YARN-8842:
--------------------------------------

Based on our offline discussion with [~wilfreds], here are the changes included 
in patch009:

- Removed getMaxAllocationUtilization from QueueMetricsForCustomResources and 
its related testcases and moved the code to YARN-8059 patch002
- Removed the unnecessary check of 
{{queueMetricsForCustomResources.isThereAnyAllocatedResource}} in 
{{QueueMetrics#getAllocatedResources}} as {{Resource.newInstance}} already 
handles an empty-map.
- Fixed all the checkstyle issues, except "'xxx' hides a field. [HiddenField]" 
kind of issues. This could only disappear if the parameter has a different name 
than the fields, which does not make sense for me.

> Update QueueMetrics with custom resource values 
> ------------------------------------------------
>
>                 Key: YARN-8842
>                 URL: https://issues.apache.org/jira/browse/YARN-8842
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-8842.001.patch, YARN-8842.002.patch, 
> YARN-8842.003.patch, YARN-8842.004.patch, YARN-8842.005.patch, 
> YARN-8842.006.patch, YARN-8842.007.patch, YARN-8842.008.patch, 
> YARN-8842.009.patch
>
>
> This is the 2nd dependent jira of YARN-8059.
> As updating the metrics is an independent step from handling preemption, this 
> jira only deals with the queue metrics update of custom resources.
> The following metrics should be updated: 
> * allocated resources
> * available resources
> * pending resources
> * reserved resources
> * aggregate seconds preempted



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to