[
https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650450#comment-16650450
]
Haibo Chen commented on YARN-8842:
----------------------------------
Thanks [~snemeth] for updating the patch! The patch looks much better to me.
In addition to the checkstyle issues (I think we can ignore the ones like
"HiddenField" and "must be private and have accessor methods"), I have one
other minor comment: In QueueInfo, all fields can be marked as final I think.
Let's also rename the methods following the pattern assert**() to check**().
+1 otherwise.
> Update QueueMetrics with custom resource values
> ------------------------------------------------
>
> Key: YARN-8842
> URL: https://issues.apache.org/jira/browse/YARN-8842
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-8842.001.patch, YARN-8842.002.patch,
> YARN-8842.003.patch, YARN-8842.004.patch, YARN-8842.005.patch,
> YARN-8842.006.patch, YARN-8842.007.patch, YARN-8842.008.patch,
> YARN-8842.009.patch, YARN-8842.010.patch, YARN-8842.011.patch
>
>
> This is the 2nd dependent jira of YARN-8059.
> As updating the metrics is an independent step from handling preemption, this
> jira only deals with the queue metrics update of custom resources.
> The following metrics should be updated:
> * allocated resources
> * available resources
> * pending resources
> * reserved resources
> * aggregate seconds preempted
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
