[
https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649193#comment-16649193
]
Szilard Nemeth commented on YARN-8842:
--------------------------------------
Hi [~haibochen]!
Fixed some checkstyle issues with patch011.
I realized there are a bunch of issues related to fields are not private and
they don't have accessor methods in test classes. I think for these classes
it's perfectly fine to access them as package-private fields.
The other ones are for builder method parameters have the same name as the
fields and they hide them: If I fixed this, it had no additional value and the
param names could be too cryptic (abbrevations, for example).
What do you think, do we have to fix any of the outstanding checkstyle issues?
Thanks!
> Update QueueMetrics with custom resource values
> ------------------------------------------------
>
> Key: YARN-8842
> URL: https://issues.apache.org/jira/browse/YARN-8842
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-8842.001.patch, YARN-8842.002.patch,
> YARN-8842.003.patch, YARN-8842.004.patch, YARN-8842.005.patch,
> YARN-8842.006.patch, YARN-8842.007.patch, YARN-8842.008.patch,
> YARN-8842.009.patch, YARN-8842.010.patch, YARN-8842.011.patch
>
>
> This is the 2nd dependent jira of YARN-8059.
> As updating the metrics is an independent step from handling preemption, this
> jira only deals with the queue metrics update of custom resources.
> The following metrics should be updated:
> * allocated resources
> * available resources
> * pending resources
> * reserved resources
> * aggregate seconds preempted
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
