[ 
https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757436#comment-16757436
 ] 

Szilard Nemeth commented on YARN-9135:
--------------------------------------

Hi [~pbacsko]!

Thanks for the review!

Very good point, we could have some problems in the future with the 
equals/hashCode.

I decided to choose making the NumaResourceAllocation class immutable.

Please check my latest patch!

> NM State store ResourceMappings serialization are tested with Strings instead 
> of real Device objects
> ----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-9135
>                 URL: https://issues.apache.org/jira/browse/YARN-9135
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-9135.001.patch, YARN-9135.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to