[
https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750049#comment-16750049
]
Peter Bacsko commented on YARN-9135:
------------------------------------
[~snemeth] there is one big problem with this change:
{{NumaResourceAllocation}} is a mutable object. If you put it into a hash-based
collection and then add something to it, the hash code will change. You can
figure out the rest.
I suggest one of the following:
1. Remove equals/hashcode
2. Make it immutable: remove {{addMemoryNode()}} and {{addCpuNode()}} methods
and inject these data from the constructor. Also make the maps immutable.
> NM State store ResourceMappings serialization are tested with Strings instead
> of real Device objects
> ----------------------------------------------------------------------------------------------------
>
> Key: YARN-9135
> URL: https://issues.apache.org/jira/browse/YARN-9135
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9135.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
