[ 
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888399#comment-16888399
 ] 

Eric Yang commented on YARN-9562:
---------------------------------

Thank you for the patch [~ebadger].

GetContainerRuntimeData is designed to return an object.  When the object is 
actually used in RuncContainerRuntime, object is casted to 
ContainerRuntimeObject.  Would it be cleaner to accept RuncContainerRuntime 
object only?  It may reduce casting errors.

Can you talk about the OCIImageTagToManifestPlugin and 
OCIManifestToResourcesPlugin?  It would help to understand the usage of 
plugins.  Thanks

> Add Java changes for the new RuncContainerRuntime
> -------------------------------------------------
>
>                 Key: YARN-9562
>                 URL: https://issues.apache.org/jira/browse/YARN-9562
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>            Priority: Major
>         Attachments: YARN-9562.001.patch
>
>
> This JIRA will be used to add the Java changes for the new 
> RuncContainerRuntime. This will work off of YARN-9560 to use much of the 
> existing DockerLinuxContainerRuntime code once it is moved up into an 
> abstract class that can be extended. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to