[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889228#comment-16889228
]
Eric Badger commented on YARN-9562:
-----------------------------------
Uploading patch 002 with unit tests added.
bq. When it is passing object, then developer may expect any type of object to
work, which is not the case. Many of the good answers argues against passing
Object for strong type language can be found here. Can we change to a subclass
please?
I'm open to changing this. What do you have in mind for subclassing instead?
bq. I think I understand the reason to make container image management as
plugins better base on your feedback. Thank you for that. Do we want to define
device plugin interface in here? CSI, CNI, GPU are examples that may need some
way to define availability of those resource, and claims of using them.
I think devices plugins are a little bit different. The plugins in this patch
are only for how to get the resources necessary to create a rootfs for the
container to run in (basically the docker image files). Device plugins would be
what we need to add on to the container to allow it to work with bind-mounts,
special runc runtimes. Those are things that we will probably want to add on in
the future (as we have with Docker), but I think they are beyond the scope of
this JIRA. Let me know if I'm misunderstanding what you're saying here.
> Add Java changes for the new RuncContainerRuntime
> -------------------------------------------------
>
> Key: YARN-9562
> URL: https://issues.apache.org/jira/browse/YARN-9562
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Eric Badger
> Assignee: Eric Badger
> Priority: Major
> Attachments: YARN-9562.001.patch, YARN-9562.002.patch
>
>
> This JIRA will be used to add the Java changes for the new
> RuncContainerRuntime. This will work off of YARN-9560 to use much of the
> existing DockerLinuxContainerRuntime code once it is moved up into an
> abstract class that can be extended.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
