[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889212#comment-16889212
]
Eric Yang commented on YARN-9562:
---------------------------------
{quote}The idea here was that ContainerRuntimeObject is specific to
RuncContainerRuntime where container.getContainerRuntimeData() could return any
arbitrary object. That way other runtimes could utilize this runtime data with
their own unique runtime object.{quote}
When it is passing object, then developer may expect any type of object to
work, which is not the case. Many of the good answers argues against passing
Object for strong type language can be found
[here|https://softwareengineering.stackexchange.com/questions/198085/is-it-poor-programming-practice-to-pass-parameters-as-objects].
Can we change to a subclass please?
I think I understand the reason to make container image management as plugins
better base on your feedback. Thank you for that. Do we want to define device
plugin interface in here? CSI, CNI, GPU are examples that may need some way to
define availability of those resource, and claims of using them.
> Add Java changes for the new RuncContainerRuntime
> -------------------------------------------------
>
> Key: YARN-9562
> URL: https://issues.apache.org/jira/browse/YARN-9562
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Eric Badger
> Assignee: Eric Badger
> Priority: Major
> Attachments: YARN-9562.001.patch
>
>
> This JIRA will be used to add the Java changes for the new
> RuncContainerRuntime. This will work off of YARN-9560 to use much of the
> existing DockerLinuxContainerRuntime code once it is moved up into an
> abstract class that can be extended.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
