[
https://issues.apache.org/jira/browse/YARN-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917798#comment-16917798
]
Weiwei Yang commented on YARN-9664:
-----------------------------------
Hello [~Tao Yang]
I just went through the patch. Most of the changes stay in activities package,
that's good.
*ActivitiesTestUtils*
{code:java}
getFirstSubNodeFromJson(JSONObject json, String... hierachicalFieldNames)
{code}
typo: {{hierachicalFieldNames}} -> {{hierarchicalFieldNames}}
*ActivitiesUtils*
Line 56: I noticed that the 1st filter is to filter out null objects, can we do
this like following?
{code:java}
activityNodes.stream().filter(e -> Objects.nonNull(e))...
{code}
*ActivityDiagnosticConstant*
{code:java}
public final static String INIT_CHECK_SINGLE_NODE_REMOVED = "Initial check: "
+ "single placement node has been removed from scheduler";
{code}
what does "single placement node" mean here?
{code:java}
public final static String QUEUE_SKIPPED_TO_RESPECT_FIFO = "Queue skipped "
+ "following applications in the queue to respect FIFO of applications";
{code}
I think we can remove "in the queue", that seems redundant.
{code:java}
public final static String
NODE_SKIPPED_BECAUSE_OF_NO_OFF_SWITCH_AND_LOCALITY_VIOLATION =
"Node skipped because of no off-switch and locality violation";
{code}
I am also not quite sure what does this mean, can you please elaborate?
*ParentQueue*
line 650: is it safe to the check: "if (node != null && !isReserved)" here?
Thanks
> Improve response of scheduler/app activities for better understanding
> ---------------------------------------------------------------------
>
> Key: YARN-9664
> URL: https://issues.apache.org/jira/browse/YARN-9664
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Tao Yang
> Assignee: Tao Yang
> Priority: Major
> Attachments: YARN-9664.001.patch, YARN-9664.002.patch
>
>
> Currently some diagnostics are not easy enough to understand for common
> users, and I found some places still need to be improved such as no partition
> information and lacking of necessary activities. This issue is to improve
> these shortcomings.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
